- Reported
-
- Issued
-
- Package
-
gix-worktree-state
(crates.io)
- Type
-
Vulnerability
- Keywords
-
#permissions
- Aliases
-
- References
-
- CVSS Score
- 5
MEDIUM
- CVSS Details
-
- Attack vector
- Local
- Attack complexity
- Low
- Privileges required
- Low
- User interaction
- Required
- Scope
- Unchanged
- Confidentiality
- None
- Integrity
- High
- Availability
- None
- CVSS Vector
- CVSS:3.1/AV:L/AC:L/PR:L/UI:R/S:U/C:N/I:H/A:N
- Patched
-
- Affected OSes
-
aixandroiddragonflyfreebsdfuchsiaillumosioslinuxmacosnetbsdopenbsdsolaris
- Affected Functions
- Version
gix_worktree_state::checkout-
Description
Summary
gix-worktree-state specifies 0777 permissions when checking out executable files, intending that the umask will restrict them appropriately. But one of the strategies it uses to set permissions is not subject to the umask. This causes files in a repository to be world-writable in some situations.
Details
Git repositories track executable bits for regular files. In tree objects and the index, regular file modes are stored as 0644 if not executable, or 0755 if executable. But this is independent of how the permissions are set in the filesystem (where supported).
gix_worktree_state::checkout has two strategies for checking out a file and marking it executable on a Unix-like operating system, one of which is vulnerable:
- If the file is created by assuming it does not already exist, correct permissions are applied, because permissions specified when opening a file are subject to the umask.
- If the file is considered possibly already to exist—even in a clean checkout if the application does not specify the option to treat the destination directory as empty—then permissions conferring unrestricted access to any user account on the system are wrongly applied, because permissions specified when calling chmod on an existing file are not subject to the umask.
Specifically, checkout::entry::checkout chooses the strategy for each file. The same strategy is usually chosen for each executable file, if no process (i.e. long running) smudge filter is in use. The strategy depends on the checkout::Options::destination_is_initially_empty value, which is passed along to checkout::entry::open_file, whose return value includes a flag indicating whether permissions still need to be set:
finalize_entry is likewise called from checkout::chunk::process_delayed_filter_results.
PoC
-
On a Unix-like system such as GNU/Linux or macOS, create a new project and define its dependencies. While the vulnerability is in gix-worktree-state, this example will use vulnerable code through the gix crate, which exposes it. Run:
cargo new checkout-index
cd checkout-index
cargo add gix gix-object
-
In the checkout-index directory, edit src/main.rs so that its entire contents are:
fn main() -> Result<(), Box<dyn std::error::Error>> {
let repo = gix::discover("has-executable")?;
let mut index = repo.open_index()?;
gix::worktree::state::checkout(
&mut index,
repo.work_dir().ok_or("need non-bare repo")?,
gix_object::find::Never, // Can also use: repo.objects.clone()
&gix::progress::Discard,
&gix::progress::Discard,
&Default::default(),
Default::default(),
)?;
Ok(())
}
-
Create the test repository that the vulnerable program will operate on. Still in the checkout-index directory, run:
git init has-executable
touch has-executable/a has-executable/b
chmod +x has-executable/b
git -C has-executable add .
It is not necessary to commit the changes, only to stage them, since the test program will check out the index.
-
Optionally, run rm has-executable/[ab] to remove the staged files from disk.
-
Run the program by issuing cargo run. The program uses gix-worktree-state to check out the index. It should terminate successfully and not issue any errors.
-
Run ls -l has-executable to inspect the permissions of the checked out files. Observe that owner, group, and other all have read, write, and execute permissions on b.
-rw-r--r-- 1 ek ek 0 Jan 9 03:38 a
-rwxrwxrwx 1 ek ek 0 Jan 9 03:38 b
With affected versions of gix-worktree-state, the output shows -rwxrwxrwx for b, whether the files were removed in step 4 or not.
-
It was not necessary to set destination_is_initially_empty to false explicitly to trigger the bug, because that is its default value. If desired, modify the program to pass true and rerun the experiment to verify that b is no longer created with excessive permissions. The modified program would change the last checkout argument from Default::default(), to:
gix::worktree::state::checkout::Options {
destination_is_initially_empty: true,
..Default::default()
},
Impact
Setting unlimited file permissions is a problem on systems where a user account exists on the system that should not have the ability to access and modify the files. That applies to multi-user systems, or when an account is used to run software with reduced abilities. (Some programs may also treat broad write permissions to mean less validation is required.)
This bug affects Unix-like systems but not Windows. The gix clone command is not believed to be affected, due to checkout_exclusive's use of destination_is_initially_empty: true. Specialized uses in which repositories are known never to have any files marked executable are unaffected. Repositories that no untrusted users can access, due to not having the ability to traverse the directories to them or due to sufficiently restrictive ACLs, are likewise unaffected.
The default value of destination_is_initially_empty is false, so some applications may be affected even if they don't attempt checkouts in nonempty directories. The 0777 permissions are applied to files that are created earlier in the same checkout, as well as those that already existed, regardless of their prior permissions. On preexisting files, 0777 is set even if overwrite_existing is false, as that prevents the checkout from changing file contents but not permissions.
Files not tracked/staged as executable are not checked out with insecure permissions. Such a file that previously existed keeps its old permissions. However, this may include executable permissions that no longer match repository metadata, as well as undesired write permissions acquired from a previous vulnerable checkout. set_mode(0o777) clears other bits, so the bug is not exacerbated by the presence of setuid/setgid bits. In some applications, the vulnerable strategy may be used only for files rewritten by a long running smudge filter or only in the presence of delays.
Advisory available under CC0-1.0
license.