Reported

December 4, 2024

Issued

December 5, 2024

Package

pprof (crates.io)

Type

INFO Unsound

Keywords

#align #uninitialized

References

• https://github.com/tikv/pprof-rs/issues/232
• https://github.com/tikv/pprof-rs/pull/255

Patched

• >=0.14.0

Affected Functions

Version

pprof::report::ReportBuilder::build

• <0.14.0

pprof::validate

• <0.14.0

Description

The library breaks the safety assumptions when using unsafe API std::slice::from_raw_parts. First, when using the API in iterator implementation (TempFdArrayIterator.next), generic type could be any type, which would create and pass a misaligned pointer to the unsafe API. Second, when validating the address, the code passed the type c_void, which could also be any type, leading to potential uninitialized memory exposure.

Two unsound usages here highlight the necessity for developers to perform type checks before doing type conversion with unsafe API.

The panic caused by the misalignment causes several downstream applications (e.g., greptimedb) to crash when using pprof::report::ReportBuilder::build.

This was patched in 0.14.0.

The developer also suggested moving to pprof2.

Advisory available under CC0-1.0 license.