Reported

April 17, 2023

Issued

April 23, 2023 (last modified: June 13, 2023)

Package

enumflags2 (crates.io)

Type

INFO Unsound

Aliases

• GHSA-qvc4-78gw-pv8p

References

• https://github.com/meithecatte/enumflags2/releases/tag/v0.7.7

Patched

• >=0.7.7

Unaffected

• <0.7.0

Description

The macro relied on an expression of the form Enum::Variant always being a variant of the enum. However, it may also be an associated integer constant, in which case there's no guarantee that the value of said constant consists only of bits valid for this bitflag type.

Thus, code like this could create an invalid BitFlags<Test>, which would cause iterating over it to trigger undefined behavior. As the debug formatter internally iterates over the value, it is also affected.

use enumflags2::{bitflags, make_bitflags};

#[bitflags]
#[repr(u8)]
#[derive(Copy, Clone, Debug)]
enum Test {
    A = 1,
    B = 2,
}

impl Test {
    const C: u8 = 69;
}

fn main() {
    let x = make_bitflags!(Test::{C});
    // printing or iterating over x is UB
}

Advisory available under CC0-1.0 license.