Reported

February 17, 2022

Issued

February 18, 2022 (last modified: June 13, 2023)

Package

enum-map (crates.io)

Type

INFO Unsound

Categories

• code-execution
• memory-corruption
• memory-exposure

Aliases

• GHSA-rxhx-9fj6-6h2m

References

• https://gitlab.com/KonradBorowski/enum-map/-/blob/master/CHANGELOG.md#version-202

Patched

• >=2.0.2

Unaffected

• <2.0.0-2

Description

Affected versions of this crate did not properly check the length of an enum when using enum_map! macro, trusting user-provided length.

When the LENGTH in the Enum trait does not match the array length in the EnumArray trait, this can result in the initialization of the enum map with uninitialized types, which in turn can allow an attacker to execute arbitrary code.

This problem can only occur with a manual implementation of the Enum trait, it will never occur for enums that use #[derive(Enum)].

Example code that triggers this vulnerability looks like this:

enum E {
    A,
    B,
    C,
}

impl Enum for E {
    const LENGTH: usize = 2;

    fn from_usize(value: usize) -> E {
        match value {
            0 => E::A,
            1 => E::B,
            2 => E::C,
            _ => unimplemented!(),
        }
    }

    fn into_usize(self) -> usize {
        self as usize
    }
}

impl<V> EnumArray<V> for E {
    type Array = [V; 3];
}

let _map: EnumMap<E, String> = enum_map! { _ => "Hello, world!".into() };

The flaw was corrected in commit b824e23 by putting LENGTH property on sealed trait for macro to read.

Advisory available under CC0-1.0 license.