Reported

February 19, 2021

Issued

March 1, 2021 (last modified: June 13, 2023)

Package

toodee (crates.io)

Type

Vulnerability

Categories

• memory-corruption

Keywords

#memory-safety #double-free

Aliases

• CVE-2021-28028
• CVE-2021-28029
• GHSA-wcvp-r8j8-47pc
• GHSA-xm9m-2vj8-fmfr

References

• https://github.com/antonmarsden/toodee/issues/13

Patched

• >=0.3.0

Affected Functions

Version

toodee::TooDee::insert_row

• <0.3.0

Description

When inserting rows from an iterator at a particular index, toodee would shift items over, duplicating their ownership. The space reserved for the new elements was based on the len() returned by the ExactSizeIterator.

This could result in elements in the array being freed twice if the iterator panics. Uninitialized or previously freed elements could also be exposed if the len() didn't match the number of elements.

These issues were fixed in commit ced70c17 by temporarily setting the length of the array smaller while processing it and adding assertions on the number of elements returned by the iterator.

Advisory available under CC0-1.0 license.