- Reported
-
- Issued
-
- Package
-
async-h1
(crates.io)
- Type
-
Vulnerability
- Keywords
-
#smuggling
#http
#reverse-proxy
#request-smuggling
- Aliases
-
- References
-
- Patched
-
- Affected Functions
- Version
async_h1::server::accept-
async_h1::server::decode-
Description
This vulnerability affects any webserver that uses async-h1 behind a reverse proxy, including all such Tide applications.
If the server does not read the body of a request which is longer than some buffer length, async-h1 will attempt to read a subsequent request from the body content starting at that offset into the body.
One way to exploit this vulnerability would be for an adversary to craft a request such that the body contains a request that would not be noticed by a reverse proxy, allowing it to forge forwarded/x-forwarded headers. If an application trusted the authenticity of these headers, it could be misled by the smuggled request.
Another potential concern with this vulnerability is that if a reverse proxy is sending multiple http clients' requests along the same keep-alive connection, it would be possible for the smuggled request to specify a long content and capture another user's request in its body. This content could be captured in a post request to an endpoint that allows the content to be subsequently retrieved by the adversary.
The flaw was corrected in commit 7df79f by ensuring that the request body is always consumed from the tcp stream before attempting to read subsequent keep-alive request headers from it.
Advisory available under CC0-1.0
license.